Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider Cythonizing at package install time instead of sdist creation time. #100

Open
mdickinson opened this issue Dec 30, 2019 · 0 comments

Comments

@mdickinson
Copy link
Owner

[from #79]

Currently, we cythonize the .pyx sources to .c files at package install time, and then include those .c files in the uploaded sdist. That causes install-time issues for users working with newer versions of Python that have backwards incompatible internal API changes; a new version of Cython can compensate for those changes, but C code generated with an older version of Cython will fail.

We should consider either requiring that Cython be present at install time, or perhaps just using Cython if it's available and falling back to the C code if not. (Of those two solutions, I'd prefer the former as being simpler, and having fewer possible failure modes.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant