Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V4: promotion/release to master + v3 maintenance branch #1004

Closed
6 of 9 tasks
rosskevin opened this issue May 10, 2016 · 26 comments
Closed
6 of 9 tasks

V4: promotion/release to master + v3 maintenance branch #1004

rosskevin opened this issue May 10, 2016 · 26 comments
Milestone

Comments

@rosskevin
Copy link
Contributor

rosskevin commented May 10, 2016

We have been discussing a release of v4 because it seems very stable (even more so than the current master), yet the only concern being that we are on the tip of the BS4 master.

v3 has been stable but is not being actively developed. BS v3 has also switched to critical bug fixes only so we should be getting near BS4 stability.

The v4 build is setup to one-step publish, we just need to enable it. We are in a position to release v4 as frequently as necessary, which would allow users to pick their stable version (meaning that the latest version may not always be incrementally better). Nonetheless, users would have bower tags and npm versions to lock onto if necessary.

@FezVrasta and I are in favor of incremental publishing of v4 and promoting it to master.

With that said, we really need some others to step up and pitch in to maintaining. @FezVrasta and I have other priorities right now and we will need additional maintainers to step up. I a have to move on to other projects. If you are interested in becoming a major contributor, please contact @FezVrasta.

Here is the proposed procedure:

Tracking issues

Use this link to filter the issues and see only the ones related to our V4 implementation:
https://github.com/FezVrasta/bootstrap-material-design/issues?utf8=%E2%9C%93&q=is%3Aissue%20is%3Aopen%20-label%3Av3%20

What I need from you:

  • If you agree with this, just 👍 with the github reactions (not a new message)
  • If you agree generally, 👍 with the github reactions and comment with your unique additions/objections
  • If you disagree, please 👎 with github reactions, and if not already mentioned, comment with your unique objection.
@nhomar
Copy link

nhomar commented May 10, 2016

addition/objection: You should manage this change in something like 2 or 3 months, and release parallely with bootstrap 4 officially. (syncronize the relase I mean).

Following this: http://blog.getbootstrap.com/2015/08/19/bootstrap-4-alpha/

@rosskevin
Copy link
Contributor Author

#1003 is a blocker to this plan. With babel-polyfill not being rolled-up properly, cross-browser support is broken.

@cybersharky
Copy link

In my experience with v4, I'd say it's ready, if only tabs were added.

@rosskevin
Copy link
Contributor Author

rosskevin commented Jun 10, 2016

Tabs are implemented.

http://rosskevin.github.io/bootstrap-material-design/components/navs/#tabs

@cybersharky
Copy link

cybersharky commented Jun 12, 2016

Ok, good, I finally got it working.

@lorvent
Copy link

lorvent commented Jul 26, 2016

alpha 3 is close to release

i hope you guys are ready for it 😄

@FezVrasta
Copy link
Contributor

It's taking ages :(

@lorvent
Copy link

lorvent commented Jul 26, 2016

yes 😢 ...but for last 2days they moved all issues into alpha 4 so there is only one issue in alpha 3 and i am guessing they may release it today.

@lorvent
Copy link

lorvent commented Jul 28, 2016

finally released and they overhauled sass variables, so i hope you will do necessary changes

@rosskevin
Copy link
Contributor Author

Blocked by #1045

@FezVrasta
Copy link
Contributor

FezVrasta commented Aug 1, 2016

@rosskevin how would you proceed with the following point?

add a "past releases link" in the v4 docs that shows the v3 pages

Should we include the v3 page inside the jekyll site of the v4 or is there a way to link to an older version of the gh-pages?
Maybe we could fork the v3 repository to bootstrap-material-design-v3 and pubblish there the old gh-page?

@FezVrasta FezVrasta changed the title Discussion: v4 promotion/release to master - v3 maintenance branch V4: promotion/release to master + v3 maintenance branch Aug 1, 2016
@FezVrasta
Copy link
Contributor

FezVrasta commented Aug 1, 2016

I have worked on the gh-page to give it some custom style, this is the result so far:

image

I'm keeping as base the BS website to avoid to write a lot of custom stuff hard to maintain.

@rosskevin
Copy link
Contributor Author

I think you need to fork a permanent v3 branch anyway, so you could just include the html pages in the new release (on gh-pages tip) and have them load the dist from the v3 maintenance branch.

@FezVrasta
Copy link
Contributor

FezVrasta commented Aug 2, 2016

Ok well maybe we could just keep a gh-pages-v3 branch and link to it in this way:

https://cdn.rawgit.com/FezVrasta/bootstrap-material-design/gh-pages-v3/index.html

Seems like the easiest way.

@FezVrasta
Copy link
Contributor

@lorvent may you point me to the variables changes they did or test the latest v4-dev and let me know if there's something we should fix? Thanks!

@FezVrasta
Copy link
Contributor

The problem with the missing BS source files has been fixed, nothing is blocking our release anymore 🎉.

Now I guess we have just to wait for the official BS release to release our code... Do we want to wait for the final release or it could be good enough wait for the first beta or the first RC?

@lorvent
Copy link

lorvent commented Aug 5, 2016

Since they are releasing new versions slowly, its better you release along with them.

i.e. as they released alpha-3, you also please release alpha 3

notably they changed something in it like labels to tags.

@FezVrasta FezVrasta modified the milestone: V4 Aug 5, 2016
@iqbalaqaba
Copy link

Maybe restyling the navigation with side-nav system on mobile devices just to make it more materialized ?

@FezVrasta
Copy link
Contributor

@iqbalaqaba may you open a dedicated issue with more details? Thanks

@iqbalaqaba
Copy link

@FezVrasta i can give you some example if you want it to, and Its not a issue, just suggestion for the next feature style 😄

@FezVrasta
Copy link
Contributor

Yes I'm asking for an "issue/ticket" just to make it easier to track it.

@iqbalaqaba
Copy link

@FezVrasta Hello, sorry for the very long reply. I already make a issue for the feature that i mentioned before. thanks 😄

@tilwinjoy
Copy link
Contributor

I see version 4.02 under releases... So is v4 officially released?

@FezVrasta
Copy link
Contributor

nope, it should be a pre-release actually.

@FezVrasta
Copy link
Contributor

I updated the v4 code-base to match with Bootstrap v4 beta.

Any help to improve the current situation is super welcome.
The building process has been dramatically simplified, there are things missing but we'll add them when needed.

@FezVrasta FezVrasta reopened this Aug 11, 2017
@FezVrasta
Copy link
Contributor

published 4.0.0-beta.3 and published new docs/website

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants