Fixing config.yml param "bin_path" - bin path is now undepending on t… #6
Conversation
…he running OS and get converted.
|
Hey @linslin, thank you for your help with this project. |
|
Oh yea, you are right. Let me try again. |
|
Allright, conflict should be solved. |
| @@ -47,6 +47,7 @@ class PhiremockProcess | |||
| */ | |||
| public function start($ip, $port, $path, $logsPath, $debug) | |||
| { | |||
| $path = realpath($path); | |||
There was a problem hiding this comment.
What do you think about adding the call to realpath when the start method is being called in Phiremock.php file? That way, this method is agnostic about how the path is built.
Would also be great to call it for logsPath variable.
There was a problem hiding this comment.
Absolutly, we thought about the logFilePathe too but we needed a quick fix for the bin_path first. You are more familiar with your codes, so please decide it by yourself. =)
There was a problem hiding this comment.
Ok. Will merge it and later move it outside the method also for logspath.
There was a problem hiding this comment.
Great! Thx m8. Followed you up =)
An other windows fix, could you please check if this still works on unix? - linslin/Yii2-Curl#57