Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lru-cache max limit #101

Open
Gianluca-Casagrande-Stiga opened this issue Dec 2, 2024 · 1 comment
Open

Lru-cache max limit #101

Gianluca-Casagrande-Stiga opened this issue Dec 2, 2024 · 1 comment

Comments

@Gianluca-Casagrande-Stiga
Copy link
Contributor

mqemitter-redis/mqemitter-redis.js

Line 28 in a09ef9f

max: 10000,

I think that put max=10000 on LRU cache can be an issue when you have to work with more than 10000 clients that could publish a message at the same time. Makes sense?
If yes, I would like to make a PR to put the max limit inside the emitter options, in order to customise it if necessary.
@mcollina
Copy link
Owner

mcollina commented Dec 5, 2024

Yes! Would you like to send a PR?

Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mcollina @Gianluca-Casagrande-Stiga