Use persistence MongoDB, but there is a problem subscriptions

[mcollina]

I used the DEMO offline mode code.
It worked well the first time.
But when I reload the page, subscriptions collection will insert a new record.
So the same clientId has two records in subscriptions collection.
Now I publish a message and connect client, we will get two offline messages.
What's wrong with me?
Thank you.

[mcollina]

Probably you are hitting some behaviors not covered by the unit tests of Mosca. It's fine to iron out bugs.
The DEMO works when you press 'run', so nothing should happen when you reload.

I tested the issue and it's present also without Mongo, so it's something else.
I'll work on this next week.

[mcollina]

Can you try https://github.com/mcollina/mosca/tree/fix-80 and see if it solves this issue?

Thanks.

[mcollina]

Ok, everything should be fixed for all persistence.
Sorry for the weird bug!

[speed1speed1]

Nice work!
This subscriptions issue has been solved.
But I find the other issue from packets collection.
Packets collection should be store the offline message.
Follow the previous steps.
I reconnect my client, subscriptions collection don't insert a new rocord.
Now my client is online.
I publish a message, my client receive a message.
But the packets collection still insert record.
when I reconnect again.
My client received a message has been received when online.

[mcollina]

It should be fixed with the latest commit. Can you please check?

[coveralls]

Coverage remained the same when pulling 1cf36c5 on fix-80 into 4f13416 on master.

[speed1speed1]

I tried again.
This Bug still exists.
My test step

1. connect and subscription client.
2. publish message
3. end client connection.
4. publish message
5. reload page (It meant to reconnect)
6. publish message
7. reload page (It meant to reconnect), I receive message again.

The 5 step, client is online.
But when I publish message, packets collection insert record again.
So in the 7 step, I can receive the message
Because the 6 step, my packets collection has been inserted a record.

[mcollina]

Ok, I got the steps to reproduce it reliably here.
It is a little bit more complicated than what I originally thought.

[mcollina]

I have updated this branch with the new fix.
I hope it's fixed now, I am not able to reproduce it again here.

Let me know if it works. Thanks for reporting this!

In any case, it will be released as 0.15.0.

[speed1speed1]

Nice!
I think this has been resolved.
Thank you very much.

[mcollina]

Released as 0.14.4.