Don't emit clientDisconnected event when force close client.

[mcollina]

Hi, I got a problem. When I force close a client use CTRL+C , Mosca not emit clientDisconnected event. Here is the code:

• Server

var server = new mosca.Server(options);
server.on('clientDisconnected', function () {
    console.log('client gone');
})

• Client

var client = mqtt.createClient();
// Works fine, mosca got the clientDisconnected event.
client.end();

var client = mqtt.createClient();
// Use CTRL+C kill the process and mosca not got the clientDisconnected event.

[mcollina]

The 'clientDisconnected' event is received one a client sends the DISCONNECT message.
It's a clean disconnect, as the connection is closed by the server. However, there is no event fired when the socket dies.

I think we need another event, 'clientErrored', or an error parameter in the 'clientDisconnected' event.

Anyone else has faced the same problem?

[haio]

Yes, a event when client abnormal disconnected would be very useful, client connection state is very important in our use case.

[haio]

An error parameter in the clientDisconnected event should be more graceful.

[mcollina]

I checked better, and it's indeed a bug introduced by the latest fix for persistance messages by @ldstein.
I will try to propose a fix asap.

This problem occurs because in case of error the cleanUp() function in https://github.com/mcollina/mosca/blob/master/lib/client.js#L515-L529 it is not called.

[haio]

Great! Thanks a lot.

[mcollina]

This should be fixed by the latest commit on this branch. Can you please confirm everything is working as expected?

[haio]

Yes, I just checked that commit, everything work as expected.

[mcollina]

Released as 0.14.4.