This repository has been archived by the owner on Feb 11, 2020. It is now read-only.
Merge default options with config files if property not specified #58
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At present, most mosca config file options do not specify a logger object.
That makes them break when, for example, trying to use verbose output mode.
Example
mosca.conf
:Then run:
Will dump an error like:
This patch makes sure all "default" options are set to default values (merging default options with those specified in a config file) instead of outright replacing them, allowing configuration files to override only what is specified, while having a reasonable guarantee that the rest of the code which may depend on a default value can continue to do so. It also has the side-effect of making the current examples work better.