Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Null safety support #35

Closed
lig opened this issue Dec 3, 2020 · 6 comments
Closed

Null safety support #35

lig opened this issue Dec 3, 2020 · 6 comments

Comments

@lig
Copy link
Contributor

lig commented Dec 3, 2020

I'm going to submit a PR for the null safety support.

It is a common practice to keep such a code in a separate branch, i.e. null-safety, to be able to support the main release in legacy mode whilst the null safety compatible release could be released from its branch.

Please, prepare the branch for null safety support PR.

@lig
Copy link
Contributor Author

lig commented Dec 4, 2020

@mchome I see, you've merged #36 PR. It wasn't my intent to get it merged into master but I can live with that. So, no new code goes into legacy releases then. That is a way to do it.
Are you going to release a new package version having "nullsafety" in suffix? This will help migrating other depending packages to null safety.

@Abhi011999
Copy link

Abhi011999 commented Dec 20, 2020

Yeah, it will be very helpful for the packages that are depending on this through pub

@lig
Copy link
Contributor Author

lig commented Dec 21, 2020

@mchome I would be happy to discuss how we can go forward from here.

@lig
Copy link
Contributor Author

lig commented Dec 30, 2020

@mchome I wouldn't mind organizing the code into a proper null-safety branch and making it ready for a null safety ready pre-release version if you give me the access. I have no intentions of taking over the project but I can help with the maintenance.

@mchome
Copy link
Owner

mchome commented Dec 31, 2020

Done.
https://pub.dev/packages/flutter_colorpicker/versions/0.4.0-nullsafety.0

@lig
Copy link
Contributor Author

lig commented Dec 31, 2020

@mchome thank you so much!

@lig lig closed this as completed Dec 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants