Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use buffer for MAC responses #87

Closed
terrillmoore opened this issue Jun 30, 2018 · 0 comments
Closed

Use buffer for MAC responses #87

terrillmoore opened this issue Jun 30, 2018 · 0 comments
Assignees
Labels

Comments

@terrillmoore
Copy link
Member

Current version of scan_mac_cmds() sets up bitmaps and "ans" fields as it scans the mac commands. Then buildDataFrame() uses the bits and the answers to create reply fields. But this means:

  1. responses are not guaranteed to be in same order as requests
  2. it's hard to have multiple responses to repeated requests.

Solution is to create a dedicated buffer for mac responses. It looks pretty easy; build it in scan_mac_cmds(), then prepend to the buffer in buildDataFrame(). We can then rip out all the flags and so forth; net size will be almost a wash.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant