Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate support for MCMD_BeaconInfoReq/MCMD_BeaconTimingAns #375

Closed
terrillmoore opened this issue Aug 18, 2019 · 2 comments
Closed

Deprecate support for MCMD_BeaconInfoReq/MCMD_BeaconTimingAns #375

terrillmoore opened this issue Aug 18, 2019 · 2 comments
Assignees

Comments

@terrillmoore
Copy link
Member

Class B support prior to 1.0.3 was pretty much broken. In 1.0.3, they finally corrected things. At that point, they deprecated MCMD_BeaconTimingReq and MCMD_BeaconTimingAns (LMIC: old names MCMD_BCNI_REQ and MCMD_BCNI_ANS.)

The code is not deleted, but now you must #define ENABLE_MCMD_BeaconTimingAns instead of #define DISABLE_MCMD_BCNI_ANS.

@terrillmoore
Copy link
Member Author

Need to rename to ENABLE_MCMD_BeaconTimingReq and make sure that the code isn't sending BeaconTimingReq when this option is enabled.

@terrillmoore
Copy link
Member Author

The 1.0.2 spec for some reason did not use symmetric names. They are BeaconInfoReq and BeaconTimingAns. The control option should still be named ENABLE_MCMD_BeaconInfoReq, and it should control both the request and the answer parsing. Somewhat academic as Class B still doesn't work in LMIC as far as I can tell.

@terrillmoore terrillmoore changed the title Deprecate support for MCMD_BeaconTimingReq/MCMD_BeaconTimingAns Deprecate support for MCMD_BeaconInfoReq/MCMD_BeaconTimingAns Aug 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant