Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pgm_read_ptr() is wrong in pgmspace.h #49

Open
terrillmoore opened this issue Feb 22, 2021 · 0 comments
Open

pgm_read_ptr() is wrong in pgmspace.h #49

terrillmoore opened this issue Feb 22, 2021 · 0 comments
Assignees
Labels

Comments

@terrillmoore
Copy link
Member

The Time library was recently updated to use pgm_read_ptr(). This reveals that the definition in our BSP is wrong.

It is:

#define pgm_read_ptr(addr) (*(const void *)(addr))

But it should be:

#define pgm_read_ptr(addr) (*(const void **)(addr))

We need to patch and make a release (v2.3.1, I think, as this is just a bug fix). The test is compiling the LMIC's network-time example with the 4450.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants