Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

couple of problems #4

Open
rebcabin opened this issue Feb 7, 2016 · 2 comments
Open

couple of problems #4

rebcabin opened this issue Feb 7, 2016 · 2 comments

Comments

@rebcabin
Copy link
Contributor

rebcabin commented Feb 7, 2016

Not sure how to fix these, but consider the following (under SBCL 1.3.1)

(let ((*print-length* 14))
  (quickcheck
    (when *testing*
      (for-all ((s (lambda () (funcall an-integer))))
        (is= s s))
      (for-all ((s (lambda () (funcall a-boolean))))
        (isnt= s (not s)))
      (for-all ((s #'a-string))
        (is= s s)))
    ))

I could not get something like ((s #'an-integer)) to work, because define, the scheme-like, didn't actually make a function, that is, instead of

    (cond ((symbolp binding)
           `(defparameter ,binding (lambda () ,@body)))
          ...

it has

    (cond ((symbolp binding)
           `(defparameter ,binding ,@body))
          ...

I didn't want to submit a pull request on this without consulting you because it might break a bunch of other stuff.

I'll submit the other problem in a different issue.

@mcandre
Copy link
Owner

mcandre commented Feb 7, 2016

If something might break, add more tests.

As long as the coverage is high, it's okay to refactor!

@rebcabin
Copy link
Contributor Author

rebcabin commented Feb 7, 2016

Ok, great. Let me see what I can do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants