-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error requiring LoopVectorization from Tullio #51
Comments
On master there's a quick attempt at a fix, much like you suggest: 7896059 The awkward bit about using Requires is that we can't let Pkg bound versions. But maybe this is simple enough to just work. Needs to be tested a bit more... |
Thanks for the quick response! Ahh yes, I see the problem, that's a bit of a sticky situation. Your fix appears to have worked for the original issue, but now I receive a similar warning when loading ┌ Warning: Error requiring ForwardDiff from Tullio:
│ LoadError: UndefVarError: SVec not defined
│ ...
│ in expression starting at /home/.julia/packages/Tullio/JZOUh/src/grad/avxdual.jl:6 It seems like another small change should fix this, too; the culprit should be this line. |
Thanks for testing... mostly I should comment out the worked example in that file! With latest commit:
|
You're not the first person to have issues from the renaming. It'd be nice if optional dependencies could specify bounds. Maybe I should have defined: const SVec = Vec |
Great - seems like everything is working on my end 👍. @chriselrod I believe that would have been sufficient in this case, though cluttering up your package's namespace is not ideal. But as you say, specifying bounds on optional dependencies (and generally being able to test different versions of optional dependencies more easily) would be much better. |
so... what is the fix? |
@AshtonSBradley the solution is to use master for now, as in @chriselrod no problem at all, this is a pretty minimal level of hassle. Thanks for sorting out the 1.6 update. |
I get the following warning on Tullio v0.2.10 when loading LoopVectorization v0.9.1:
I believe it is due to the renaming of an internal struct
SVec
in previous versions of VectorizationBase toVec
in current versions.I'm not familiar enough with your internals to make a PR to fix this, but naively it looks like a simple find and replace.
The text was updated successfully, but these errors were encountered: