Package calling searchsortedfirst with non sorted ranges

[KristofferC]

In 1.6.1 the following behavior changed:

1.6.0:

julia> searchsortedfirst(1.0:-0.1:0.1, 0.3)
8

julia> searchsortedfirst(collect(1.0:-0.1:0.1), 0.3)
1

1.6.1:

julia> searchsortedfirst(1.0:-0.1:0.1, 0.3)
1

julia> searchsortedfirst(collect(1.0:-0.1:0.1), 0.3)
1

This causes the test here

AxisKeys.jl/test/_basic.jl

Line 106 in cddf60f

@test [V4[Near(x)] for x in xs] == [V5[Near(x)] for x in xs]

to fail.

The issue seems to be that the package is using searchsortedfirst but the range it passes in is not sorted:

AxisKeys.jl/src/selectors.jl

Line 67 in cddf60f

iplus = searchsortedfirst(range, sel.val)

4|debug> st
In findindex(sel, range) at /Users/kristoffercarlsson/.julia/packages/AxisKeys/G3Okw/src/selectors.jl:66
 66  function findindex(sel::Near, range::AbstractRange)
 67      iplus = searchsortedfirst(range, sel.val)
 68      # "index of the first value in a greater than or equal to x"
>69      if abs(range[iplus]-sel.val) < abs(range[iplus-1]-sel.val)
 70          return iplus
 71      else
 72          return iplus-1
 73      end
 74  end

About to run: (getindex)(1.0:-0.1:0.1, 0)
4|julia> range
1.0:-0.1:0.1

4|julia> issorted(range)
false

Perhaps a rev was forgotten to be passed to searchsortedfirst?

[mcabbott]

Thanks, that does look wrong.

Looks like it has other bugs, too, when I try to test it more deeply:

julia> AxisKeys.findindex(Near(0.1), 3:0.1:4)
ERROR: BoundsError: attempt to access 11-element StepRangeLen{Float64, Base.TwicePrecision{Float64}, Base.TwicePrecision{Float64}} at index [0]