Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Solver] Optimize Disassembler #70

Open
mbrown1413 opened this issue May 16, 2024 · 0 comments
Open

[Solver] Optimize Disassembler #70

mbrown1413 opened this issue May 16, 2024 · 0 comments
Labels
bt feature Feature in BurrTools major feature A feature which will take a long time to implement

Comments

@mbrown1413
Copy link
Owner

mbrown1413 commented May 16, 2024

Currently the disassembler is fairly slow. Ideally, we rewrite it such that any Grid operations aren't on the critical path, similar to how the assembler already works. The current disassembler will still be necessary for custom arbitrary constraints in the future.

How GENDA disassembler works

One example of a disassembly that's slower than it probably should be: Slow Disassembly Test.json

Some other low-hanging fruit:

  • Pieces are copied with all of their extra unneeded info, like label, bounds, etc. The disassembler doesn't need any info except the id, voxels, and attributes. Implement a method like Piece.clearExtraInfo() for working piece copies in the disassembler internals.
@mbrown1413 mbrown1413 converted this from a draft issue May 16, 2024
@mbrown1413 mbrown1413 added major feature A feature which will take a long time to implement bt feature Feature in BurrTools labels May 16, 2024
@mbrown1413 mbrown1413 added this to the 1.0 or earlier milestone May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bt feature Feature in BurrTools major feature A feature which will take a long time to implement
Projects
Status: No status
Development

No branches or pull requests

1 participant