Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-evaluate reverse proxy implementation once reqwest has caught up with hyper and axum #1

Open
mbr opened this issue Dec 24, 2023 · 0 comments
Labels
tech-debt Technical debt

Comments

@mbr
Copy link
Owner

mbr commented Dec 24, 2023

An open PR adds direct conversion of incoming axum requests into reqwest ones. The discussion also links a draft PR that upgrades to hyper 1.0.

Overall this development should be monitored. rockslide currently does quite a few hacks in reverse_proxy (e.g. casting the method into a string and reparsing it), many of which are due to library incompatibilities (e.g. at the time of writing reqwest depended on http=^0.2 while axum already was on http=1. If these can be unified, the code of reverse_proxy::reverse_proxy could potentially be greatly simplified.

@mbr mbr added this to the Production ready milestone Dec 31, 2023
@mbr mbr added the tech-debt Technical debt label Dec 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tech-debt Technical debt
Projects
None yet
Development

No branches or pull requests

1 participant