fix(autocomplete): Fixed suggestion box visibility

Fixed a bug in the show method of the SuggestionList class that caused the suggestion box to be displayed even when there was no items to show.
mbenford · Dec 2, 2013 · c2b43c6 · c2b43c6
1 parent 0c75803
commit c2b43c6
Show file tree

Hide file tree

Showing 5 changed files with 11 additions and 2 deletions.
diff --git a/build/ng-tags-input.js b/build/ng-tags-input.js
@@ -302,7 +302,7 @@ angular.module('tags-input').directive('autoComplete', ["$document","$timeout","
                 self.query = query;
                 loadFn({ $query: query }).then(function(items) {
                     self.items = getDifference(items, tags);
-                    if (items.length > 0) {
+                    if (self.items.length > 0) {
                         self.show();
                     }
                 });

diff --git a/build/ng-tags-input.min.zip b/build/ng-tags-input.min.zip
diff --git a/build/ng-tags-input.zip b/build/ng-tags-input.zip
diff --git a/src/auto-complete.js b/src/auto-complete.js
@@ -61,7 +61,7 @@ angular.module('tags-input').directive('autoComplete', function($document, $time
                 self.query = query;
                 loadFn({ $query: query }).then(function(items) {
                     self.items = getDifference(items, tags);
-                    if (items.length > 0) {
+                    if (self.items.length > 0) {
                         self.show();
                     }
                 });

diff --git a/test/auto-complete.spec.js b/test/auto-complete.spec.js
@@ -127,6 +127,15 @@ describe('autocomplete-directive', function() {
             expect(isSuggestionsBoxVisible()).toBe(false);
         });
 
+        it('hides the suggestions list when there is no items left to show', function() {
+            // Act
+            tagsInput.getTags.andReturn(['Item1', 'Item2', 'Item3']);
+            loadSuggestions(['Item1', 'Item2', 'Item3']);
+
+            // Assert
+            expect(isSuggestionsBoxVisible()).toBe(false);
+        });
+
         it('hides the suggestion box when the input field becomes empty', function() {
             // Arrange
             changeInputValue('foobar');