Fix wifi cannot configure as default network interface #377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh wow this is a nice fix, very clean! Just one question, would you be able to implement this for the other wifi drivers (e.g. in COMPONENT_WHD/whd_mac/interface/whd_interface.cpp and TARGET_WICED/wiced_interface/default_wifi_interface.cpp)? Fine to just this one in this PR but we'd have to do the others in a subsequent PR. |
This fixes WiFi doesn't get linked in when configued as default network interface.
|
OK, I would also add this fix to other wifi drivers in this PR. |
This requires support for weak symbol override. Object files arcived in static library don't always participate in linking, dependent on linker and link order. The steps below pull in the override object file anyway even though it comes from static library: 1. Add e.g. GCC linker option "--undefined=<LINK_FOO>" 2. Add <LINK_FOO> function with 'extern "C"' in override source file See: https://stackoverflow.com/questions/42588983/what-does-the-gnu-ld-undefined-option-do
ccli8
force-pushed
the
support_wifi_override_symbol_pretend_undefined
branch
from
b96ecd6 to
aab8e20
Compare
|
Applied this fix to all wifi drivers under |
multiplemonomials
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
This fixes WiFi cannot configure as default network interface, e.g.
"esp8266.provide-default": true. This configuration requires support for weak symbol override. Object files archived in static library don't always participate in linking, dependent on linker and link order. The steps below introduced in this PR pull in the override object file anyway even though it comes from static library:--undefined=<LINK_FOO><LINK_FOO>function withextern "C"in override source fileSee: https://stackoverflow.com/questions/42588983/what-does-the-gnu-ld-undefined-option-do
NOTE: This provides an alternative to #373 and would be more reasonable.
Pull request type