Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration in pylint directly ? #13

Open
Pierre-Sassoulas opened this issue Jul 5, 2022 · 5 comments
Open

Integration in pylint directly ? #13

Pierre-Sassoulas opened this issue Jul 5, 2022 · 5 comments

Comments

@Pierre-Sassoulas
Copy link

Pierre-Sassoulas commented Jul 5, 2022

Hello, pylint maintainer here.

This project looks great ! I really like the logo, but it also seems to already have a lot of features and a nice overall code design too.

We happen to have an issue to have a similar feature directly in pylint (pylint-dev/pylint#5403)

What's your opinion on it ? Would it make sense to include pylint-ignore inside pylint directly ? Should we simply advertise pylint-ignore and/or pylint-silent as a solution in the doc and close our baseline issue?

Thanks in advance for your insight.

@mbarkhau
Copy link
Owner

mbarkhau commented Jul 5, 2022

Right now I've pinned pylint==2.13.9 due some changes that break pylint-ignore.

Long term I think it would be good to have ignore/silence as options directly in pylint yes. I may find some time to look into it over the next few months and work on a PR, but no guarantees.

In the short term, a reference in the documentation would be a good stop-gap.

@jamesquilty
Copy link
Contributor

jamesquilty commented Apr 22, 2023

@mbarkhau Thanks again for creating pylint-ignore! The CHANGELOG entry for version 2022-1025 says that the pylint version requirement is pylint<2.13 but you indicate above pylint==2.13.9 compatibility. I'd like to use pylint's --recursive option which was introduced in version 2.13, so the difference in version requirement is important for me. Could you please clarify the latest version of pylint which is compatible with pylint-ignore 2022-1025?

@mbarkhau
Copy link
Owner

The CHANGELOG is correct. The comment above was written before the discovery of the some incompatibilities with pylint>=2.13.

I will not be working on this and encourage you to look into working on pylint-dev/pylint#5403 rather than this project.

@nimrodV81
Copy link

@mbarkhau I'd like to contribute here
can you explain the change that's forced you to pin pylint's version?

@mbarkhau
Copy link
Owner

mbarkhau commented May 3, 2023

Sorry, I can't quite remember, it was a while ago.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants