Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preview/export: support more fonts? #52

Open
alexmyczko opened this issue Mar 23, 2021 · 6 comments
Open

Preview/export: support more fonts? #52

alexmyczko opened this issue Mar 23, 2021 · 6 comments

Comments

@alexmyczko
Copy link

Thanks for PanWriter, but the font dialog is very limited, maybe add support for this?

https://github.com/alexmyczko/fnt

@mb21
Copy link
Owner

mb21 commented Mar 24, 2021

Thanks for the feedback! This is definitely something I've been thinking about how to add best.

It would be easy to add all the fonts you've installed on your system to the dropdown and use those in the preview. But what happens if you export the document as HTML and somebody opens it that doesn't have that font installed? Should we include a webfont for that case? Google fonts?

@alexmyczko
Copy link
Author

alexmyczko commented Mar 24, 2021

It should be included as woff2, see woff2_compress, if license permits (it does for all fonts available by fnt). Definitely do not link to the internet for privacy reasons, see the links at fnt README.md.

I can test on Linux and macOS (having all system/user fonts in the list would already be a great improvement)

@shaneknysh
Copy link

I would love to be able to add a new font as well. Adding the ability to insert the font as a <link> or @import would mean it is the responsibility of the user to ensure the font they add to the editor is also available in any generated document.

@mb21
Copy link
Owner

mb21 commented Jan 18, 2022

You should be able to add custom CSS for the preview with @import or directly with @font-face commands (see the README.md), though I haven't tried it recently...

@shaneknysh
Copy link

shaneknysh commented Jan 18, 2022 via email

@mb21 mb21 changed the title Please support more fonts? Preview/export: support more fonts? Jan 19, 2022
@mb21
Copy link
Owner

mb21 commented Jan 19, 2022

Okay yes, let's keep this issue about the preview (and export), I've created #93 for the use-case with loading custom css into the editor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants