Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows installer file type association problematic #31

Open
linquize opened this issue Aug 22, 2020 · 8 comments
Open

Windows installer file type association problematic #31

linquize opened this issue Aug 22, 2020 · 8 comments

Comments

@linquize
Copy link

Windows installer:
User cannot opt-out file type association.
File type association in Windows registry is problematic.
After installing panwriter from installer,
Explorer -> Right Click -> New -> Text Document is removed because some registry values are wrong.

I want to opt-out file type association.

@linquize
Copy link
Author

@mb21
Copy link
Owner

mb21 commented Aug 23, 2020

Thanks for the report. But seems there is little we can do until this is fixed in Electron..?

@linquize
Copy link
Author

linquize commented Aug 23, 2020

One thing you could do: release a windows portable exe as well as nsis?
"win": { "target": [ "portable", "nsis" ] }

@mb21
Copy link
Owner

mb21 commented Aug 23, 2020

Did you verify that that would fix it?

I'm not a Windows-user... but sounds also like something that should somehow be configurable in the registry or somewhere?

@linquize
Copy link
Author

linquize commented Aug 24, 2020

This is not to "fix", but to produce one more output: portable executable. The problematic nsis setup is also produced. Please release both.
Since 2 outputs are produced, user can choose to download portable version.

@mb21
Copy link
Owner

mb21 commented Aug 24, 2020

Yes, but have you verified that the portable version doesn't have this problem? I don't understand why it would be different...?

@linquize
Copy link
Author

NSIS setup writes file assoxiations to Windows registry, because you put fileAssociations in package.json. electron-builder will generate write registry code in NSIS script.

Portable exe extracts files to a temporary directory before every run. It does not write to Windows registry.
Therefore, portable exe does not have such problem

@mb21
Copy link
Owner

mb21 commented Aug 24, 2020

I'll take a look for the next release... meanwhile, you can also build it yourself...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants