Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass maxOptions to Selectize. Fixes #48 #49

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

tmslnz
Copy link

@tmslnz tmslnz commented Jun 23, 2015

No description provided.

@nilshoerrmann
Copy link
Contributor

Thanks Tommaso. Would you mind adding a new version (1.1.2) to the extension.meta.xml file as well? Thanks!

@tmslnz
Copy link
Author

tmslnz commented Jun 24, 2015

“I always forget about that one…”
— Gerard Depardieu, Andie McDowell in Green Card (1990)

@nilshoerrmann
Copy link
Contributor

:D

@nitriques
Copy link

LGTM!

@tmslnz
Copy link
Author

tmslnz commented Aug 24, 2015

Hi Nils,

I’ve noticed that this hasn’t been merged yet. Maybe it just became forgotten?

Anyway I’ve integrated your latest changes so it can now be merged again. Re bumping versions in the XML, I’d rather have you do it since the previous PR developed conflicts on the extension.meta.xml file after you worked on it. Simpler if you bump it when/if you end up merging this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants