[#336] Archiefactiedatum validation [Backend] #337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #337 +/- ##
==========================================
+ Coverage 77.44% 77.60% +0.16%
==========================================
Files 223 223
Lines 7058 7109 +51
Branches 133 133
==========================================
+ Hits 5466 5517 +51
Misses 1468 1468
Partials 124 124 ☔ View full report in Codecov by Sentry. |
SilviaAmAm
force-pushed
the
feature/336-archiefactiedatum-validation
branch
from
33f11a8 to
aa27bd3
Compare
svenvandescheur
requested changes
Sep 12, 2024
| @@ -249,6 +250,11 @@ def update(self, request, *args, **kwargs): | |||
| return super().update(request, *args, **kwargs) | |||
|
|
|||
| def perform_destroy(self, instance: DestructionList) -> None: | |||
| if not instance.all_items_can_be_deleted(): | |||
| raise ValidationError( | |||
There was a problem hiding this comment.
Shouldn't this be a ZaakArchiefactiedatumInFuture as well?
There was a problem hiding this comment.
If I raise here the ZaakArchiefactiedatumInFuture then it will give a 500 error response, but if I raise the ValidationError then it will respond with a 400 status to the client.
svenvandescheur
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partly fixes #336