Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/issue 69 #70

Closed
wants to merge 2 commits into from
Closed

Fix/issue 69 #70

wants to merge 2 commits into from

Conversation

gabor-boros
Copy link
Contributor

@gabor-boros gabor-boros commented Jul 22, 2020

Description

The current version, which is stated to be Python 3 only, actually gets into Python 2 installations because of a missing python_requires update

This PR closes #69.

Note

Also bumped the history and version number to help you prepare the new release. Of course, Yanking 2.0.0 would be needed to completely fix the issue, or I could update the PR to use a post version.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 93.491% when pulling bd9af40 on gabor-boros:fix/issue-69 into 30d8bf0 on maxmind:master.

@gabor-boros
Copy link
Contributor Author

@oschwald Do you have any opinion on the versioning related "question"?

@oschwald
Copy link
Member

Thanks! I merged from the CLI and released 2.0.1. I yanked 2.0.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

New version is breaking Python 2 installs - missing setup.py python_requires update
3 participants