Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New version is breaking Python 2 installs - missing setup.py python_requires update #69

Closed
scorchio opened this issue Jul 22, 2020 · 3 comments
Closed

New version is breaking Python 2 installs - missing setup.py python_requires update #69

scorchio opened this issue Jul 22, 2020 · 3 comments

Comments

@scorchio
Copy link

scorchio commented Jul 22, 2020 •
edited
Loading

Hi,

The current version, which is stated to be Python 3 only, actually gets into Python 2 installations because of a missing python_requires update:

MaxMind-DB-Reader-python/setup.py

Line 112 in 30d8bf0

python_requires=">=2.7, !=3.0.*, !=3.1.*, !=3.2.*, !=3.3.*, !=3.4.*",

Could you please fix this?
@gabor-boros
Copy link
Contributor

Opening a PR in some minutes to fix this

@gabor-boros gabor-boros mentioned this issue Jul 22, 2020
Closed
@youtux
Copy link

youtux commented Jul 22, 2020 •
edited
Loading

Please consider yanking the 2.0.0 release on PYPI.

EDIT: Sorry, I saw later that you already plan to yank 2.0.0. Forget my comment.

@oschwald
Copy link
Member

This should be resolved. Thanks for raising it.

@jwhitlock jwhitlock mentioned this issue Aug 3, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix/issue 69
4 participants
@scorchio @oschwald @youtux @gabor-boros