Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dunn and missing values #70

Closed
stikpet opened this issue Jun 9, 2024 · 5 comments
Closed

Dunn and missing values #70

stikpet opened this issue Jun 9, 2024 · 5 comments

Comments

@stikpet
Copy link

stikpet commented Jun 9, 2024

I think the function for Dunn still counts as sample size the number of scores in the categorical field, even if there is no value in the numerical field, i.e. it includes missing values. I don't think this is correct....

@maximtrp
Copy link
Owner

Handling missing values is out of scope of this package. But something should be done with it, I agree. Maybe throwing a warning will be enough... Anyway, thank you for drawing attention to it.

@stikpet
Copy link
Author

stikpet commented Jun 13, 2024

a simple dropna() at the beginning should be enough to fix things, or indeed a warning about them.

@maximtrp
Copy link
Owner

Dropping something silently is not a good thing. I will think about it. Maybe let's have a look at some references, bigger packages with millions of users.

@stikpet
Copy link
Author

stikpet commented Jun 13, 2024

I'm not familiar with other packages in Python that can perform the test. In R however there is dunn.test from the library dunn.test that doesn't give any warnings and simply removes the missing values. Another R library FSA has a dunnTest function that does add a warning "Some rows deleted from 'x' and 'g' because missing data". A little program from IBM named SPSS Statistics also does not give any warnings and simply removes the missing values in the calculations.

Thanks for still answering on this and of course for sharing your library.

@maximtrp
Copy link
Owner

Fixed in v0.10.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants