Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Truncated Biographies #26

Open
Rodeoclash opened this issue Nov 4, 2013 · 2 comments
Open

Truncated Biographies #26

Rodeoclash opened this issue Nov 4, 2013 · 2 comments

Comments

@Rodeoclash
Copy link

I'm not sure if this is a bug or a "feature" of the Echonest API. Sometimes when I fetch a list of biographies for an artist I only get back 7 or 8 words followed by an ellipses, it looks as if the biography has been truncated in length. This only occurs on some artists, not all.

A good example is Lipps Inc. Using their biography example from the documentation:

http://developer.echonest.com/api/v4/artist/biographies?api_key=FILDTEOIK2HBORODV&name=Lipps%20Inc&format=json&results=1&start=0&license=cc-by-sa

"biographies": [{"text": "Lipps, Inc. (pronounced like \"lip sync\") was a studio pop/rnb band formed in 1979 in Minneapolis, Minnesota, USA by Steven Greenberg, who wrote and produced all of the group's music, and who also played several instruments. They are best known for their second hit single \"Funkytown\

However when I request the biography via the gem I get:

"Before hard funksters like Prince and the Time hit the ..."

Why the discrepancy? Is this on the gems side or Echonests side?

@maxehmookau
Copy link
Owner

That's very strange. If you could provide a failing test for the biography method where this happens that would be awesome. I'll investigate it though, hopefully it's something fairly obvious :)

@maxehmookau
Copy link
Owner

I suspect that it's the echonest API. Some of the returned biographies have the truncated value set to true. That said, that request should be returning a list of biographies some of which are truncated and some are not. So I reckon that it's not iterating around the returned JSON objects properly when it creates Echonest::Biography
Feel free to fix this or I will try to fix it when I get the chance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants