Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Game.getBlock: Assignment to parameter in arguments object #100

Open
deathcap opened this issue May 7, 2014 · 1 comment
Open

Game.getBlock: Assignment to parameter in arguments object #100

deathcap opened this issue May 7, 2014 · 1 comment

Comments

@deathcap
Copy link
Collaborator

deathcap commented May 7, 2014

The profiler in Chrome 34.0.1847.131 reports this function:

Game.prototype.getBlock = function(pos) {
  pos = this.parseVectorArguments(arguments)
  return this.voxels.voxelAtPosition(pos)
}

is not optimizable because: "Assignment to parameter in arguments object"

screen shot 2014-05-06 at 9 28 42 pm
@fritx
Copy link

fritx commented May 14, 2014

bad

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@deathcap @fritx