Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds rollup #10

Merged
merged 6 commits into from
Nov 28, 2023
Merged

adds rollup #10

merged 6 commits into from
Nov 28, 2023

Conversation

adamjanicki2
Copy link
Contributor

@adamjanicki2 adamjanicki2 commented Nov 27, 2023

Adds command to package.json which runs rollup, to build iife and cjs build files. These files are not minified. The command is npm run build:js. The output files are stored in src/

Copy link

netlify bot commented Nov 27, 2023

Deploy Preview for vastly ready!

Name Link
🔨 Latest commit be13057
🔍 Latest deploy log https://app.netlify.com/sites/vastly/deploys/6565fa75dea5af000888b241
😎 Deploy Preview https://deploy-preview-10--vastly.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

.gitignore Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
package.json Outdated
"watch:html": "npx @11ty/eleventy --config=_build/.eleventy.cjs --watch",
"watch": "npm run watch:html",
"build:docs": "npx typedoc --out docs src/"
"build:docs": "npx typedoc --out docs src/",
"build:js": "rollup -c"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait, why delete npx? That was needed regardless! Please read up a bit on what it does and you'll see why.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I got confused from the slack conversation

package.json Outdated Show resolved Hide resolved
Copy link
Member

@LeaVerou LeaVerou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I re-added npx so I think it's good to go

@adamjanicki2 adamjanicki2 merged commit 7d5533f into main Nov 28, 2023
4 checks passed
@adamjanicki2 adamjanicki2 deleted the rollup branch November 28, 2023 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants