Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Survey produces no mission items if Mission is in "Terrain Frame" #10557

Open
AndKe opened this issue Feb 2, 2023 · 3 comments
Open

Survey produces no mission items if Mission is in "Terrain Frame" #10557

AndKe opened this issue Feb 2, 2023 · 3 comments
Assignees

Comments

@AndKe
Copy link
Contributor

AndKe commented Feb 2, 2023

Expected Behavior

Survey grids should work equally _ regardless of altitude frame.

Current Behavior

Survey grid is not generated (as output during upload) if terrain frame is selected

Steps to Reproduce:

please see video: https://drive.google.com/file/d/1cO4LV8ajPKtE2si55mNuFMI5NBMEyVZg/view?usp=sharing

System Information

  • Operating System: Ubuntu22.10
  • QGC Version:
  • QGC build: current HEAD
  • Flight Controller: SITL
  • Autopilot (with version): Copter, current release.

Detailed Description

  • video says all.
@AndKe
Copy link
Contributor Author

AndKe commented Feb 2, 2023

update: This is not really related to mission start, but rather the altitude frame of the survey:
Screenshot from 2023-02-02 15-12-49

@AndKe AndKe changed the title Survey produces no mission items if Mission start specifies "Terrain Frame" Survey produces no mission items if Mission is in "Terrain Frame" Feb 3, 2023
@Davidsastresas Davidsastresas self-assigned this Feb 7, 2023
@AndKe
Copy link
Contributor Author

AndKe commented May 4, 2023

@Davidsastresas how is your schedule? - back in February I think this was number 6 in your queue. :)

@Davidsastresas
Copy link
Member

Davidsastresas commented May 7, 2023

Sorry for taking this long @AndKe. I was still busy with other ongoing projects but I spared some time to fix this one:

#10678

It turns out to be a bug where QGC was expecting to have terrain data on the surveys if these had terrain frame. The behaviour you showed in your video was only present when this terrain info was not present, with terrain info the survey was generated correctly, so I pulled that string and it turns out that was the reason.

Thank you very much for reporting this, and sorry for taking this long to address it. Let me know how it goes, and if it fixes the problem for you please close the issue and comment on the PR. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants