Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bridge discord messages sent with @silent as m.notice #168

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ginnyTheCat
Copy link

@ginnyTheCat ginnyTheCat commented Dec 8, 2024

Bridges discord messages marked as @silent as matrix notices.

Notice the bell icon in the corner
Discord message sent with @silent featuring a snoozing bell icon
Matrix message content JSON showing it's of type m.notice

Copy link
Member

@sumnerevans sumnerevans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably the more correct way to bridge these is as normal messages with an empty m.mentions so that nobody gets mentioned.

@ginnyTheCat
Copy link
Author

As far as I understand an empty m.mentions still sends a notification, just not a ping. While a discord silent messages won't send any notification even if explicitly enabled in the room. Idk if this is realizable some other way than a m.notice.

@tulir
Copy link
Member

tulir commented Dec 11, 2024

m.notice doesn't necessarily disable notifications, it's just a marker for automated messages. Bridging @silent properly probably needs a new MSC to define a new field to signal silent messages and a corresponding push rule

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants