Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove from "Do not contact" don't have a default value in the parameter #136

Closed
gorkaguerrero opened this issue Oct 24, 2017 · 0 comments
Closed

Comments

@gorkaguerrero
Copy link
Contributor

gorkaguerrero commented Oct 24, 2017

Hi!

According to the API documentation, the function "remove from do not contact" ( link here to documentation ) has, as second parameter, the channel with its default value is 'email'.

But the function in the code (file lib/Api/Contacts.php), line 312 doesnt have the default value
public function removeDnc($id, $channel)
should be
public function removeDnc($id, $channel = 'email')
according to the documentation

PD: also the documentation is wrong, because the example uses 'addDnc()' instead of 'removeDnc()'
$contactApi->addDnc($contactId, $channel);

All the best

@gorkaguerrero gorkaguerrero changed the title Remove from "Do not contact" not have a default parameter Remove from "Do not contact" don't have a default parameter Oct 24, 2017
@gorkaguerrero gorkaguerrero changed the title Remove from "Do not contact" don't have a default parameter Remove from "Do not contact" don't have a default value in the parameter Oct 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants