Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can it remove the 1st workspace if the window is closed? #17

Open
laichiaheng opened this issue Aug 15, 2024 · 5 comments
Open

Can it remove the 1st workspace if the window is closed? #17

laichiaheng opened this issue Aug 15, 2024 · 5 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@laichiaheng
Copy link

It doesn't close it automatically, so there is always an empty workspace in front of other workspaces.

@maurges
Copy link
Owner

maurges commented Aug 15, 2024

If you remove this empty workspace in front of others, you can't move new windows there, which means you can never create new desktops with this extension. In KDE, unlike old gnome that I used, you can't move windows to a workspace that doesn't exist.

In fact you can try it without support of this extension: you can delete the last desktop by right-clicking on the pager and selecting "delete desktop". Now try to move the window on the last workspace to a workspace to the right of it. Can you do it? What happens when you do?

I can imagine creating new shortcuts specifically for "move window to a new desktop" but I think it's more trouble than it's worth.

@laichiaheng
Copy link
Author

laichiaheng commented Aug 15, 2024

If you remove this empty workspace in front of others, you can't move new windows there, which means you can never create new desktops with this extension. In KDE, unlike old gnome that I used, you can't move windows to a workspace that doesn't exist.

In fact you can try it without support of this extension: you can delete the last desktop by right-clicking on the pager and selecting "delete desktop". Now try to move the window on the last workspace to a workspace to the right of it. Can you do it? What happens when you do?

I can imagine creating new shortcuts specifically for "move window to a new desktop" but I think it's more trouble than it's worth.

I don't mean the last empty workspace, but the first workspace after I close the window, just like Gnome.

@maurges
Copy link
Owner

maurges commented Aug 15, 2024

Do you mean the situation where you close the last window on a desktop, and move your view one desktop to the right, and this empty desktop still exists on the left? I remember I tried to do it, but this broke the desktop switching animation. (Which is now also broken with the rewrite for plasma 6, sighhh). This would be nice to have, but I don't feel strongly about it to implement it myself now. I'll gladly accept patches!

@maurges maurges added enhancement New feature or request help wanted Extra attention is needed labels Aug 15, 2024
@laichiaheng
Copy link
Author

Do you mean the situation where you close the last window on a desktop, and move your view one desktop to the right, and this empty desktop still exists on the left? I remember I tried to do it, but this broke the desktop switching animation. (Which is now also broken with the rewrite for plasma 6, sighhh). This would be nice to have, but I don't feel strongly about it to implement it myself now. I'll gladly accept patches!

Yes, it is what I mean. Unfortunately I don't know how to write codes.

@bigimattia
Copy link
Contributor

Just made a PR that should address this.
Feel free to test it out using this fork and give feedback since it's a pretty big change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants