Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

when call qrr.settings.callback error raised #3

Open
phc2003 opened this issue Oct 23, 2020 · 0 comments
Open

when call qrr.settings.callback error raised #3

phc2003 opened this issue Oct 23, 2020 · 0 comments

Comments

@phc2003
Copy link

phc2003 commented Oct 23, 2020

qrcode-reader is a great plugin! ease to use!
When use data-qrr.settings.callback to set a callback function,raise some error like"Type Error: qrr.settings.callback is not a function....",I think "qrr.settings.callback(qrr.codes)" or "qrr.settings.callback(value)" (line 249 in qrcode-reader.js) can not treat as a function,so,I try to change code to "
var fn = window[qrr.settings.callback];
if (typeof (fn) === "function") {
fn(qrr.settings.multiple?qrr.codes:value);
}
",and it's run.

otherwise, It would be even better if then text "qrr-nodata" and "qrr-loading-message" (line 94/99 in qrcode-reader.js) can use localize parameters!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant