Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI control not work #8

Open
ducxinh opened this issue Jun 30, 2020 · 4 comments
Open

UI control not work #8

ducxinh opened this issue Jun 30, 2020 · 4 comments

Comments

@ducxinh
Copy link

ducxinh commented Jun 30, 2020

Hey.

Can you tell me where I went wrong?
Looks like My code lacks style for control

video-result

@ducxinh ducxinh closed this as completed Jul 11, 2020
@tomastuser
Copy link

I am also having this problem. Did you figure it out in the end?

@matvp91
Copy link
Owner

matvp91 commented Oct 1, 2020

@tomastuser Could you provide a sample project (codesandbox)?

@matvp91 matvp91 reopened this Oct 1, 2020
@tomastuser
Copy link

Here is the codesandbox sample: https://codesandbox.io/s/wonderful-feistel-eulvy

I managed to find a workaround by adding a CSS class called .material-icons and referencing the Material Icons Round font face in it. When inspecting the UI elements in browser it looks they all use .material-icons selector but in controls.css provided by shaka-player they only reference material-icons-round.

Also the video in fullscreen mode doesn't stretch and continues to stay small as can be seen in the sample. Should I open another issue for this problem or is it ok to report it here?

@matvp91
Copy link
Owner

matvp91 commented Dec 11, 2020

@tomastuser @ducxinh201 I'm sorry it took such a long time for me to answer to your issue. Before I'd want to investigate your issue, I first made sure shaka-player-react is properly migrated to shaka-player's latest stable version (3.0.6).

I quickly made a codesandbox to verify if this is still an issue with the updated shaka-player version, and it doesn't seem so. You can see the result here: https://codesandbox.io/s/condescending-benz-ybhih. Could you upgrade to v1.1.0 and give it another spin?

As a side note, I've imported the css directly from shaka-player/dist/controls.css and let the bundler deal with it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants