-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] - Episode icon isn't centered #357
Comments
Well, it's supposed to be a thumbnail right not some huge image. Personally I'd like to see a minimalist option that fits more episodes on the page at once. I mean look at how much whitespace there is on your screenshot. If the issue is that grid layout needs bigger images, then maybe let people supply both row and grid images and use smaller images for the rows and bigger images for the grids? i.e. episode0-row.png, episode0-grid.png, and failback to episode0.png if the row and grid options aren't there. Or just tell people what size image to use for grid and what (smaller) size image to use for rows. Or, have a compact row option that's separate from the current row option (for backwards compatibility)? Lots of options. |
Let me try it with moving the thumbnail over; right now I think it's |
#358 changes the layout a bit and removes some of the extra padding around the images and description. After the deploy preview is done building, I'll put in a link here to review. |
OK, so you can see it here https://deploy-preview-358--sample-castanet.netlify.app/ Again, the thumbnails are larger than yours, so it won't look exactly the same, but it takes up 3 columns instead of 4, and I removed some of the padding around them. |
Describe the bug
You did fix the problem where the episode description text wasn't aligned with other episodes, but also the icon is not centered in the place where it is. See this attached screenshot to get an idea.
At a minimum I think the description text should be centered with respect to the show icon and not have quite so much white space between the icon and the text.
I don't know the right way to fix it, it just doesn't seem to look great the way it is right now.
The text was updated successfully, but these errors were encountered: