Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Post new release #17

Closed
SuperQ opened this issue Oct 26, 2019 · 12 comments
Closed

Post new release #17

SuperQ opened this issue Oct 26, 2019 · 12 comments

Comments

@SuperQ
Copy link

SuperQ commented Oct 26, 2019

It would be useful to tag a new release to include #13.
@SuperQ SuperQ mentioned this issue Oct 26, 2019
Closed
@mattn
Copy link
Owner

mattn commented Oct 30, 2019

Tagged v0.0.2

@mattn mattn closed this as completed Oct 30, 2019
@SuperQ
Copy link
Author

SuperQ commented Oct 30, 2019

It looks like the same commit was tagged

@mattn
Copy link
Owner

mattn commented Oct 30, 2019

Because nothing changed after #13

@SuperQ
Copy link
Author

SuperQ commented Oct 30, 2019

No, v0.0.2 is tagged to the same commit as v0.0.1. It's still ac7d848, not b33132ba.

@SuperQ
Copy link
Author

SuperQ commented Oct 30, 2019

image

@mattn
Copy link
Owner

mattn commented Oct 30, 2019

Yes, no updates from v0.0.1. v0.0.1 is tagged on last commit.

@mattn
Copy link
Owner

mattn commented Oct 30, 2019

b33132b is merge commit. Not real commit.

@SuperQ
Copy link
Author

SuperQ commented Oct 30, 2019

Yes, and that's important.

See the compare: v0.0.2...master

@mattn
Copy link
Owner

mattn commented Oct 30, 2019

Updated v0.0.2

@SuperQ
Copy link
Author

SuperQ commented Oct 30, 2019

Sadly, updating in-place seems to break things due to Go caching. I think you will have to publish v0.0.3. :-(

@mattn
Copy link
Owner

mattn commented Oct 30, 2019

Please try again.

@SuperQ
Copy link
Author

SuperQ commented Oct 30, 2019

🎉 prometheus/node_exporter#1529 Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mattn @SuperQ