Use golang.org/x/term for the IsTerminal() API #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Packages from the golang.org domain are likely to be more widely used
than github.com/mattn/go-isatty. Therefore, this can reduce the number
of dependencies for consumers of github.com/mattn/go-colorable, who may
already have golang.org/x/term in their dependency chain.
Newer versions of golang.org/x/term require Go versions more recent than
1.15 [1]. Therefore, the minimum needed version was carefully chosen to
avoid bumping the Go version.
[1] golang.org/x/term commit a79de5458b56c188
golang/term@a79de5458b56c188
golang/go#36460
|
Related: briandowns/spinner#156 |
|
Ping |
|
Supported OSs of x/term are not enough to replace go-isatty. ex: appengine, cygwin. |
I see. Thanks for looking into it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Packages from the golang.org domain are likely to be more widely used than github.com/mattn/go-isatty. Therefore, this can reduce the number of dependencies for consumers of github.com/mattn/go-colorable, who may already have golang.org/x/term in their dependency chain.
Newer versions of golang.org/x/term require Go versions more recent than 1.15 [1]. Therefore, the minimum needed version was carefully chosen to avoid bumping the Go version.
[1] golang.org/x/term commit a79de5458b56c188
golang/term@a79de5458b56c188
golang/go#36460