chore(upgrade): v1.0.0 to polkadot-sdk v1.1.0 #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The goal of this PR is to upgrade from v1.0.0 to v1.1.0. Update benchmarks for custom pallets and overhead. References - [Polkadot Forum](https://forum.polkadot.network/t/polkadot-release-analysis-v1-1-0/3988) - [Release Notes](https://github.com/paritytech/polkadot-sdk/releases/tag/polkadot-v1.1.0) Co-authored-by: Enddy Dumbrique <[email protected]> Co-authored-by: Matthew Orris <[email protected]>
mattheworris
commented
Oct 31, 2023
| @@ -788,6 +794,18 @@ impl pallet_frequency_tx_payment::Config for Runtime { | |||
| type MaximumCapacityBatchLength = MaximumCapacityBatchLength; | |||
| } | |||
|
|
|||
| #[cfg(any(not(feature = "frequency-no-relay"), feature = "frequency-lint-check"))] | |||
There was a problem hiding this comment.
This section added in preparation for Async Backing
mattheworris
commented
Oct 31, 2023
| type CheckAssociatedRelayNumber = RelayNumberStrictlyIncreases; | ||
| type CheckAssociatedRelayNumber = RelayNumberMonotonicallyIncreases; | ||
| // TODO: Remove this when Async Backing is activated and the feature is set for cumulus-pallet-parachain-system | ||
| #[cfg(feature = "parameterized-consensus-hook")] |
There was a problem hiding this comment.
Benchmark overhead panics if this feature is enabled.
mattheworris
commented
Oct 31, 2023
| @@ -830,6 +859,8 @@ impl pallet_aura::Config for Runtime { | |||
| type DisabledValidators = (); | |||
| type MaxAuthorities = AuraMaxAuthorities; | |||
| type AllowMultipleBlocksPerSlot = ConstBool<false>; | |||
| #[cfg(feature = "experimental")] | |||
There was a problem hiding this comment.
This feature is not enabled, but should it be?
Repository owner
deleted a comment from
1291945816
Mar 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of this PR is to upgrade from v1.0.0 to v1.1.0.
Update benchmarks for custom pallets and overhead.
References
Goal
The goal of this PR is
Closes
Discussion
Checklist