mkmf adds Logging module v 1.0.12

[arielvalentin]

I tried upgrading to the latest version of screenshot but run into this error when running cucumber tests:
undefined method 'html_safe' for #<IO:<STDOUT>> (ActionView::Template::Error)

The error comes from this block of code:

  6      - if defined?(message) && message.present?
  7           .short
  8             = sanitize_and_auto_link(message.html_safe, truncate: true, length: 50)

Which, AFAICT comes from MakeMakefile::Logging.message http://www.rubydoc.info/stdlib/mkmf/2.0.0/MakeMakefile/Logging

Does the library require use of mkmf in cucumber?

capybara-screenshot/lib/capybara-screenshot/cucumber.rb

Line 2 in 14af3c1

require 'mkmf'

[mattheworiordan]

@arielvalentin sorry to hear that. mkmf was introduced when imgcat support was added, see 29d6f1b. However, looking at that commit now, it's not obvious why mkmf is needed at all. Have you tried just removing the require to see what happens? I am going to ask the author of that commit why he included mkmf, but as far as I can tell, it is not needed...

[mattheworiordan]

FYI, I believe 012208c fixes this issue now. Pleas reopen if that is not the case.

[arielvalentin]

This fix works great!