Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Fuubar #135

Closed
lacco opened this issue Jul 7, 2015 · 3 comments
Closed

Support for Fuubar #135

lacco opened this issue Jul 7, 2015 · 3 comments

Comments

@lacco
Copy link
Contributor

lacco commented Jul 7, 2015

Is there any interest in getting capybara-screenshot working with https://github.com/thekompanee/fuubar ? I added the following line to spec_helper.rb which made the integration work:

Capybara::Screenshot::RSpec::REPORTERS["Fuubar"] = Capybara::Screenshot::RSpec::TextReporter

In case we want to add it to capybara-screenshot core, I can make a separate pull request...

@mattheworiordan
Copy link
Owner

I am not sure why this is needed? I don't really follow as Fuubar looks like an RSpec reporter?

@lacco
Copy link
Contributor Author

lacco commented Jul 8, 2015

I am a little unsure about the difference of formatter vs reporter, I only observed that using --format Fuubar for RSpec breaks the injection of capybara-screenshot in https://github.com/mattheworiordan/capybara-screenshot/blob/master/lib/capybara-screenshot/rspec.rb#L86 . Adding Fuubar to Capybara::Screenshot::RSpec::REPORTERS fixed the issue for me, so that screenshot links are now included in my reported failures.

@mattheworiordan
Copy link
Owner

@lacco well I am happy to merge in a PR that adds Fuubar support, but unfortunately this is not something I am familiar with myself so won't be spending time on this myself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants