Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fails to analyze namespaces with top level sexprs which aren't seqable? #20

Closed
matthewdowney opened this issue Apr 12, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@matthewdowney
Copy link
Owner

For example it fails to even run tests in the following namespace:

(defn add [a b] (+ a b))

1

^:rct/test
(comment 
  (add 1 2) ;=> 3
)

I noticed this issue when running on a namespace where I'd accidentally left a literal 1 as a top level form.

In that sense it was helpful, but the code should be updated to reflect that

  • there are top-level forms that rewrite-clj says are sexpr-able?
  • calling (first (z/sexpr zloc)) on such forms is not necessarily safe
@matthewdowney matthewdowney added the bug Something isn't working label Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant