Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shift checkpoint files from test_chkpt to tmp #64

Open
Chiffafox opened this issue Nov 2, 2022 · 1 comment
Open

Shift checkpoint files from test_chkpt to tmp #64

Chiffafox opened this issue Nov 2, 2022 · 1 comment
Assignees
@Chiffafox
Labels
enhancement New feature or request

Comments

@Chiffafox
Copy link
Collaborator

Right now some of the tests -- specifically, test_chkpt -- are saving some files to disk in the head directory, then deleting them with shutil.rmtree. The proper way of handling this is is with a tmp_path.
@Chiffafox Chiffafox added the enhancement New feature or request label Nov 2, 2022
@Chiffafox Chiffafox self-assigned this Nov 2, 2022
@matthewcarbone
Copy link
Owner

@Chiffafox yep there's even a standard library class for this. It's really great when used in a context manager.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Chiffafox Chiffafox

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Chiffafox @matthewcarbone