Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MM-1025]: Fixed the infinite loading state of tooltip modal #1129

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

[MM-1025]: Fixed the infinite loading state of tooltip modal #1129

wants to merge 5 commits into from
+96 −2

Conversation

Kshitij-Katiyar
Copy link
Contributor

@Kshitij-Katiyar Kshitij-Katiyar commented Sep 27, 2024 •
edited
Loading

Summary

Fixed the infinite loading state of the tooltip modal

Issue link

Fixes #1025

Screenshots

Existing

Screenshot from 2024-09-20 16-10-59

Updated

Screenshot from 2024-09-23 15-15-59

Testing step

  • Create a Jira subscription
  • Create a Jira issue on the same project
  • Hover over the link of the mattermost subscription post for the Jira issue
  • Disable the internet from the throttling option of the network tab in the developer window of the browser(ctrl + shift + I)
  • Hover over the link of the mattermost subscription post again

@raghavaggarwal2308 raghavaggarwal2308 added 2: Dev Review Requires review by a core committer 3: QA Review Requires review by a QA tester labels Sep 27, 2024
@raghavaggarwal2308 raghavaggarwal2308 added this to the v4.3.0 milestone Sep 27, 2024
@raghavaggarwal2308 raghavaggarwal2308 removed the 2: Dev Review Requires review by a core committer label Nov 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raghavaggarwal2308 raghavaggarwal2308 raghavaggarwal2308 approved these changes

@wiggin77 wiggin77 wiggin77 approved these changes

@AayushChaudhary0001 AayushChaudhary0001 Awaiting requested review from AayushChaudhary0001

Assignees

@Kshitij-Katiyar Kshitij-Katiyar

Labels
3: QA Review Requires review by a QA tester
Projects
None yet
Milestone
v4.3.0
Development

Successfully merging this pull request may close these issues.

When link tooltip fails to load issue, the spinner continues to spin forever with no user feedback
3 participants
@Kshitij-Katiyar @wiggin77 @raghavaggarwal2308