Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error handling in completeCalendar to avoid panic #8

Open
mickmister opened this issue Apr 23, 2020 · 1 comment
Open

Improve error handling in completeCalendar to avoid panic #8

mickmister opened this issue Apr 23, 2020 · 1 comment
Labels
Difficulty/1:Easy Easy ticket Good First Issue Suitable for first-time contributors Hacktoberfest Help Wanted Community help wanted Tech/Go Type/Bug Something isn't working Up For Grabs Ready for help from the community. Removed when someone volunteers

Comments

@mickmister
Copy link
Contributor

PR #7 was created to be clear about configuring the plugin properly, as a remedy to avoid a panic in the plugin. The plugin should instead be resilient to this and handle the case of this error. See this comment for details #7 (comment)

There was an index out of range error occurring here:

userId := strings.Split(state, "_")[1]

@mickmister mickmister added Help Wanted Community help wanted Good First Issue Suitable for first-time contributors Type/Bug Something isn't working Difficulty/1:Easy Easy ticket Tech/Go Up For Grabs Ready for help from the community. Removed when someone volunteers labels Apr 23, 2020
@mickmister
Copy link
Contributor Author

Ideally the root cause of the problem is solved, instead of just avoiding the panic. The configuration issue should be brought to the attention of the user when they initially try to connect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Difficulty/1:Easy Easy ticket Good First Issue Suitable for first-time contributors Hacktoberfest Help Wanted Community help wanted Tech/Go Type/Bug Something isn't working Up For Grabs Ready for help from the community. Removed when someone volunteers
Projects
None yet
Development

No branches or pull requests

3 participants