Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add webapp debug command #421

Closed
wants to merge 2 commits into from
Closed

Add webapp debug command #421

wants to merge 2 commits into from

Conversation

mickmister
Copy link
Contributor

Summary

The Makefile command expects this debug command to be defined

Ticket Link

@mickmister mickmister requested a review from hanzei December 14, 2023 22:47
@codecov Codecov
Copy link

codecov bot commented Dec 14, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (848d1da) 33.39% compared to head (36f827e) 33.39%.
Report is 1 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master     #421   +/-   ##
=======================================
  Coverage   33.39%   33.39%           
=======================================
  Files          22       22           
  Lines        3980     3980           
=======================================
  Hits         1329     1329           
  Misses       2520     2520           
  Partials      131      131

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

hanzei
hanzei reviewed Dec 15, 2023
View reviewed changes
webapp/package.json Outdated Show resolved Hide resolved
@hanzei hanzei added the 2: Dev Review Requires review by a core committer label Dec 15, 2023
spirosoik
spirosoik approved these changes Dec 15, 2023
View reviewed changes
Copy link
Member

@spirosoik spirosoik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. let's just cross-check @hanzei comment

spirosoik
spirosoik reviewed Dec 15, 2023
View reviewed changes
Copy link
Member

@spirosoik spirosoik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In a separate note as the lint is failing should we we fix the issue now?

@mickmister
Copy link
Contributor Author

@spirosoik Yes this lint issue has come up for all plugin projects suddenly. I've pinged Delivery about it here mattermost/mattermost-plugin-jira#1005 (comment)

@mickmister mickmister requested a review from hanzei December 15, 2023 18:01
@hanzei hanzei added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core committer labels Dec 18, 2023
@mickmister
Copy link
Contributor Author

/update-branch

@mickmister mickmister mentioned this pull request Dec 19, 2023
Merged
@mickmister
Copy link
Contributor Author

Closing in favor of #428

@mickmister mickmister closed this Dec 20, 2023
@hanzei hanzei deleted the webapp-debug-command branch December 20, 2023 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spirosoik spirosoik spirosoik approved these changes

@hanzei hanzei hanzei approved these changes

Assignees
No one assigned
Labels
4: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mickmister @spirosoik @hanzei