Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add display of the "Reviewers" field to the pull request creation event template #856

Open
San4es opened this issue Nov 27, 2024 · 0 comments · May be fixed by #859
Open

Add display of the "Reviewers" field to the pull request creation event template #856

San4es opened this issue Nov 27, 2024 · 0 comments · May be fixed by #859
Assignees
@Kshitij-Katiyar

Comments

@San4es
Copy link
Contributor

San4es commented Nov 27, 2024 •
edited
Loading

At the moment, the "Assignees" field displays:

mattermost-plugin-github/server/plugin/template.go

Lines 210 to 214 in 827e881

template.Must(masterTemplate.New("assignee").Funcs(funcMap).Parse(`
{{- if .Assignees }}
Assignees: {{range $i, $el := .Assignees -}} {{- if $i}}, {{end}}{{template "user" $el}}{{end -}}
{{- end -}}
`))

I suggest to add the "Reviewers" field as well to notify PR reviewers in the pulls_created event via their mention.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Kshitij-Katiyar Kshitij-Katiyar

Labels
None yet
Projects
Brightscout Plugin Maintenance
Status: Submitted / In Review
Milestone
No milestone
2 participants
@San4es @Kshitij-Katiyar