Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mentioned Pull Panel Available #654

Open
AdrianoDee opened this issue Mar 10, 2023 · 11 comments · May be fixed by #775
Open

Mentioned Pull Panel Available #654

AdrianoDee opened this issue Mar 10, 2023 · 11 comments · May be fixed by #775
Labels
Help Wanted Community help wanted Type/Enhancement New feature or improvement of existing feature

Comments

@AdrianoDee
Copy link

Hi,
Is there a way to have also the https://github.com/pulls/mentioned panel, for open PRs, as we have all the others (Created,Assigned,Review requests)? In case there's already a solution for this: sorry I did not find it, my bad!

@mickmister
Copy link
Contributor

Hi @AdrianoDee! Thanks for creating this issue to discuss this. Would you be interested in implementing this feature?

@hanzei hanzei added the Type/Enhancement New feature or improvement of existing feature label Mar 23, 2023
@hanzei
Copy link
Contributor

hanzei commented Mar 23, 2023

@AdrianoDee What is the use case of such a counter/panel? What value does it provide when there are already notifications?

@AdrianoDee
Copy link
Author

Hi @mickmister, @hanzei:

  • I would be interested but I'm not an expert in Go so it could take some time;
  • the point is that with notifications you get notified when you are mentioned and that's it. Having that panel would allow to monitor how the PR you are mentioned are going on. This comes from a project I'm involved in in which each PR is automatically labelled and, based on the labels, reviewers are tagged but do not become assignee.

@mickmister
Copy link
Contributor

@AdrianoDee Great thanks for explaining 👍

I think this feature would bring value as you describe. @hanzei I think this is a welcomed improvement. Thoughts on making this help wanted?

@Kshitij-Katiyar
Copy link
Contributor

@mickmister @hanzei Should we make this HW ticket or we should work on this.

@hanzei hanzei added Help Wanted Community help wanted Up For Grabs Ready for help from the community. Removed when someone volunteers labels Oct 9, 2023
@hanzei
Copy link
Contributor

hanzei commented Oct 9, 2023

@Kshitij-Katiyar Let's keep is as a HW

@cyrusjc
Copy link
Contributor

cyrusjc commented Apr 17, 2024

Hi I'd like to pick this up but have some questions:

I'm assuming we want to add this as an overlay trigger to the sidebars, in which case which icon would we want to use?

@Kshitij-Katiyar
Copy link
Contributor

Hi I'd like to pick this up but have some questions:

I'm assuming we want to add this as an overlay trigger to the sidebars, in which case which icon would we want to use?

@mickmister @hanzei Can we provide an icon for the sidebar here?

@mickmister
Copy link
Contributor

Hi @cyrusjc, thanks for your interest in contributing 👍

I'm thinking the font awesome comment icon may be appropriate here. This is available by setting the class name fa fa-comment https://fontawesome.com/icons/comment?f=classic&s=solid. @matthewbirtch Do you have any thoughts on this?

@matthewbirtch
Copy link

Ideally we shift all the github plugin icons to compass icons, but that can be done later. For now we can use font-awesome. I would suggest the outlined version of the comment icon though
image

@cyrusjc cyrusjc linked a pull request May 3, 2024 that will close this issue
@cyrusjc
Copy link
Contributor

cyrusjc commented May 3, 2024

I'm slotted in the icon shown below. I couldn't get the FA v5 icons to work so I found the closest looking one in v4.

https://fontawesome.com/v4/icon/comment-o

image

@hanzei hanzei removed the Up For Grabs Ready for help from the community. Removed when someone volunteers label May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Help Wanted Community help wanted Type/Enhancement New feature or improvement of existing feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants