-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mentioned Pull Panel Available #654
Comments
Hi @AdrianoDee! Thanks for creating this issue to discuss this. Would you be interested in implementing this feature? |
@AdrianoDee What is the use case of such a counter/panel? What value does it provide when there are already notifications? |
Hi @mickmister, @hanzei:
|
@AdrianoDee Great thanks for explaining 👍 I think this feature would bring value as you describe. @hanzei I think this is a welcomed improvement. Thoughts on making this help wanted? |
@mickmister @hanzei Should we make this HW ticket or we should work on this. |
@Kshitij-Katiyar Let's keep is as a HW |
Hi I'd like to pick this up but have some questions: I'm assuming we want to add this as an overlay trigger to the sidebars, in which case which icon would we want to use? |
@mickmister @hanzei Can we provide an icon for the sidebar here? |
Hi @cyrusjc, thanks for your interest in contributing 👍 I'm thinking the font awesome comment icon may be appropriate here. This is available by setting the class name |
I'm slotted in the icon shown below. I couldn't get the FA v5 icons to work so I found the closest looking one in v4. |
Hi,
Is there a way to have also the https://github.com/pulls/mentioned panel, for open PRs, as we have all the others (
Created
,Assigned
,Review requests
)? In case there's already a solution for this: sorry I did not find it, my bad!The text was updated successfully, but these errors were encountered: