Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v3.7 link is not correct for Linux #523

Closed
3 tasks done
yuya-oc opened this issue May 1, 2017 · 1 comment
Closed
3 tasks done

v3.7 link is not correct for Linux #523

yuya-oc opened this issue May 1, 2017 · 1 comment
Labels
Milestone

Comments

@yuya-oc
Copy link
Contributor

yuya-oc commented May 1, 2017

I confirm (by marking "x" in the [ ] below):


Summary
Following links are incorrect.

  • .tar.gz: x64
  • .deb: amd64, i386

It seems that filename format has been changed by electron-builder.

Steps to reproduce
Start Jenkins job to cut release.

Possible fixes

  1. Configure electron-builder to explicitly set format.
  2. Fix renaming script of Jenkins job.
@yuya-oc
Copy link
Contributor Author

yuya-oc commented May 2, 2017

Fixed the Jenkins job. The filename format was changed by electron-userland/electron-builder#803 .

It's correct in Debian though, but we should keep previous format for consistence of URLs now.

@yuya-oc yuya-oc closed this as completed May 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant