Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modular library #47

Open
Nartagnan opened this issue Mar 26, 2021 · 1 comment
Open

Modular library #47

Nartagnan opened this issue Mar 26, 2021 · 1 comment
Labels
Difficulty/2:Medium Medium ticket Hacktoberfest Help Wanted Community help wanted Tech/Go Type/Enhancement New feature or improvement of existing feature Up For Grabs Ready for help from the community. Removed when someone volunteers

Comments

@Nartagnan
Copy link

Hello,

Would it be possible to convert the hard coded list of images and slots into a modular one ?
A folder with

  • The images
  • A yaml file for each image, with the same name, containing slots (as actually),
    And a script that build automatically the list with what it find in the library.
    (I think it is the file "assets.go" but I'm not sure)

According to this PR:
https://github.com/mattermost/mattermost-plugin-memes/pull/46/files
the difficult thing seems to be the line of bytes, is it the file hard coded ?

It can be manually launched (no need to rebuild every morning) and it could return errors in command line, as it would be only done by the admin and not the users.

(sorry I'm no dev)

In any case, thank you for the plugin so far !

@hanzei
Copy link
Contributor

hanzei commented Mar 29, 2021

Sure, that seems like a valid approach. 2/5 that we should keep the existing library as it is and add this as a modular extension.

On the implementation side a slash command would be a much better UX to add new memes.

@hanzei hanzei added Difficulty/2:Medium Medium ticket Help Wanted Community help wanted Tech/Go Type/Enhancement New feature or improvement of existing feature Up For Grabs Ready for help from the community. Removed when someone volunteers labels Mar 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Difficulty/2:Medium Medium ticket Hacktoberfest Help Wanted Community help wanted Tech/Go Type/Enhancement New feature or improvement of existing feature Up For Grabs Ready for help from the community. Removed when someone volunteers
Projects
None yet
Development

No branches or pull requests

3 participants